Skip to content

Conversation

@kakserpom
Copy link
Contributor

@kakserpom kakserpom changed the title docs(superglobals): a guide chapter on Superglobals docs(superglobals): a guide chapter on Superglobals #499 Dec 21, 2025
@kakserpom kakserpom force-pushed the 499_document_superglobals branch from 6d9b5b2 to 80a62d7 Compare December 21, 2025 15:52
ptondereau
ptondereau previously approved these changes Dec 21, 2025
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crystal clear documentation!
A quick note that I would like to add but in a very specific environment:
With FrankenPHP in worker mode, if you want - to mimic the same behavior of the hooks php_rinit/rshutdown, you need to overwrite the sapi_activate/deactivate.
But during sapi_activate, the super globals are not accessible (and cause a crash).
Anyway LGTM

@kakserpom kakserpom force-pushed the 499_document_superglobals branch from e3f32b3 to 8581ecf Compare December 21, 2025 16:30
@ptondereau ptondereau merged commit 78939fc into extphprs:master Dec 21, 2025
62 of 63 checks passed
@coveralls
Copy link

coveralls commented Dec 21, 2025

Pull Request Test Coverage Report for Build 20412683047

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.779%

Totals Coverage Status
Change from base Build 20412315510: 0.0%
Covered Lines: 1658
Relevant Lines: 4634

💛 - Coveralls

@Xenira Xenira mentioned this pull request Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants